dts: renesas_ra: Changing to describe clocks with DeviceTree's standard manner #78365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_renesas
DNM
soburi
force-pushed
the
renesas_ra_clock_rework
branch
4 times, most recently
from
d782c9b to
8320b5d
Compare
soburi
changed the title
zephyrbot
added
area: Clock Control
area: Devicetree
platform: Renesas RA
zephyrbot
requested review from
decsny,
duynguyenxa,
galak,
KhiemNguyenT,
nordic-krch and
thaoluonguw
gmarull
reviewed
Sep 16, 2024
| * @return the node's full name with unit-address as a sequence of tokens, | ||
| * with no quotes | ||
| */ | ||
| #define DT_NODE_FULL_NAME_UNQUOTED(node_id) DT_CAT(node_id, _FULL_NAME_UNQUOTED) |
There was a problem hiding this comment.
add tests and macros.bnf if needed.
There was a problem hiding this comment.
Thank you for the review. I forgot about it. I've added it, so please check it again.
soburi
force-pushed
the
renesas_ra_clock_rework
branch
2 times, most recently
from
adf82ef to
7006d58
Compare
zephyrbot
requested review from
57300,
jeremybettis,
nashif,
nordicjm and
tejlmand
gmarull
previously approved these changes
Sep 17, 2024
duynguyenxa
previously approved these changes
Sep 18, 2024
Thank you for your review. Please check also zephyrproject-rtos/hal_renesas#36. |
soburi
force-pushed
the
renesas_ra_clock_rework
branch
from
f775934 to
44746f5
Compare
Update HAL to improve the BSP clock setting process. Signed-off-by: TOKITA Hiroshi <[email protected]>
Like some other string properties, I will add a derived form to FULL_NAME to make it easier to reference from macros. Signed-off-by: TOKITA Hiroshi <[email protected]>
Changes the path name of a DTS node so that it can be used as the stem of a BSP macro. All nodes to be changed are referenced via labels, so only the name is changed. Signed-off-by: TOKITA Hiroshi <[email protected]>
DeviceTree typically references the clock source using the `clocks` property defined in `base.yaml`, so we'll change it to this. Also delete the custom clock source definitions in `renesas,ra-cgc-pclk-block.yaml`, `renesas,ra-cgc-pclk.yaml`, and `renesas,ra-cgc-pll.yaml`. Signed-off-by: TOKITA Hiroshi <[email protected]>
Move the process of replacing numerical values with macros to the header, and set the division ratio in a numeric without using macros in the device tree. Change `clk-div` defined in `renesas,ra-cgc-pclk.yaml` to `div`. Signed-off-by: TOKITA Hiroshi <[email protected]>
Adding the macros `RA_CGC_CLK_SRC` and `RA_CGC_CLK_DIV` that derive the BSP clock settings from the DeviceTree node settings. I also define some aliases to fill in the gaps with the BSP naming conventions. Signed-off-by: TOKITA Hiroshi <[email protected]>
soburi
force-pushed
the
renesas_ra_clock_rework
branch
from
44746f5 to
9c5ef6b
Compare
|
This needs to be merged before #78959 (or any other PR that includes hal-renesas updating). |
|
The hal module has been updated so it has been rebased. |
gmarull
approved these changes
Oct 2, 2024
duynguyenxa
approved these changes
Oct 4, 2024
|
@nordic-krch |
nordic-krch
approved these changes
Oct 8, 2024
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeviceTree typically references the clock source using the
clocksproperty defined in
base.yaml, so we'll change it to this.Move the process of replacing numerical values with macros to
the header, and set the division ratio in a numeric without
using macros in the device tree.